ArrayList: Exception in thread "main" java.lang.NullPointerException -


i still have problem when try add person. code suppose detect invalid name , birthday, , not add person personlist. however, because i'm not able birthday until code read it, person object can added when loop finished. problem occurs when try test add invlid person name and/or birthday. shows:

failed add person: invalid name!!

new record:

name: null"

birthday: unkown dob

has been added!

exception in thread "main" java.lang.nullpointerexception @ instruction.readinstruction(instruction.java:272)  @ epb.main(epb.java:12)      else if(words[0].equalsignorecase("add"))                 {                        person p = new person();                      string s1 = line.substring(words[0].length()).trim();                     string[] s2 = s1.split(";");                     if(s2.length>=2)// s2[0] = " name testing three" s2[1] = " birthday 13-05-1981" , s2[2]=" address.."                     {                         for(int i=0; i<s2.length;i++)                         {                             string s3 = s2[i].trim(); // "delete leading space" s2[0] = "name testing three" s2[1] = "birthday 13-05-1981"                             string[] s4 = s3.split("\\s+"); //s4[0] = name; s4[1] = testing; s4[2]=three                                if(s4.length>=2) // s2[1]=birthday 13-05-1986 has length of 2                             {                                 if(s4[0].equalsignorecase("name"))                                 {                                         //system.out.println(s4[1]);                                     string name="";                                     if(functions.namevalidation(s4[1]))                                     {                                         for(int j=2;j<s4.length;j++)                                         {                                             name = s4[1] + " " + s4[j];                                         }                                         if(functions.namevalidation(name))                                         {                                             p.setname(name);                                         }                                         else                                                                                         {                                             system.out.println("failed add person: invalid name!");                                             break;                                         }                                      }                                                                                else                                     {                                         system.out.println("failed add person: invalid name!!");                                         break;                                     }                                 }//end of word equals name                                     //-----------------------------------------------------------------                                 else if(s4[0].equalsignorecase("birthday") && s4.length ==2)                                 {                                     if(functions.datevalidation(s4[1]))                                     {                                         try                                          {                                             p.setbirthdaystring(s4[1]);                                         }                                          catch (parseexception e)                                          {                                                 //e.printstacktrace();                                         }                                     }                                     else                                     {                                         system.out.println("failed add person: invalid birthday format");                                         break;                                     }                                 }                                     //end of word equals birthday                                     //-----------------------------------------------------------------                         boolean notfound = false;                         for(person p1: personlist)                         {                             if(p1.getname().equals(p.getname()))                             {                                 if(p1.getbirthdaystring().equals(p.getbirthdaystring()))                                     {                                     system.out.println("information in record" +"\n" + "name: "+ p.getname() + "\n" + "birthday: " + p.getbirthdaystring() + "\n" +"has been updated");                                     p1.setemail(p.getemail());                                     p1.setphone(p.getphone());                                     p1.setaddress(p.getaddress());                                      notfound = true;                                 }                             }                         }                         if (!notfound)                         {                             if(functions.namevalidation(p.getname()) && functions.datevalidation(p.getbirthdaystring()))                             {                                 system.out.println("new record: " +"\n"+"name: " + p.getname() + "\""+ "\n"+ "birthday: " + p.getbirthdaystring() + "\nhas been added!");                                     personlist.add(p);                              }                             fileio.outdata(personlist, outputfilename);                              }                         system.out.println();                 }

i think meant in final loop instead of iterating on personlist , checking @ each step if contains name , birthday of p, check condition each element in iteration kind of this:

p1.getname().equals(p.getname())

instead of personlist.contains(p.getname())

and

p1.getbirthdaystring().equals(p.getbirthdaystring())

instead of personlist.contains(p.getbirthdaystring())

this fix logic bug, , exception, since won't calling contains while iterating through collection.

edit: still have bug you're trying add p personlist in same loop (in "else" block: personlist.add(p)). way you're doing not getting exception, it's trying add person p each p1 in list that's not equal it. fix need keep boolean inside loop checks if matches found (true if of conditions above p1 ever checked), , add p personlist outsite loop, if said boolean not true.

in conclusion, modified code iterating loop:

boolean found = false; for(person p1: personlist)         {             if(p1.getname.equals(p.getname()))             {                 if(p1.getbirthdaystring.equals(p.getbirthdaystring()))                                             {                     system.out.println("information in record" +"\n" + "name: "+ p.getname() + "\n" + "birthday: " + p.getbirthdaystring() + "\n" +"has been updated");                     p1.setemail(p.getemail());                     p1.setphone(p.getphone());                     p1.setaddress(p.getaddress());                     fileio.outdata(personlist, outputfilename);                      found = true;                  }              }          } if (!found) {         system.out.println("new record has been added!");         personlist.add(p);         fileio.outdata(personlist, outputfilename);  }

Comments

Post a Comment

Popular posts from this blog

jquery - How can I dynamically add a browser tab? -

since using iframes house external pages are, accounts "not preferred method" , disallowed sites (flickr, one), want dynamically generate browser tabs. e.g., when user submits form, want dynamically generate tab on browser in response submitted. e.g., might want add new tab url like: http://www.bigsurgarrapata.com/contact how in jquery? you want form target attribute action attribute. http://www.w3schools.com/tags/att_form_target.asp browsers have ultimate control on result of target attribute open new tab value of _blank. <form action="contact_submit.php" target="_blank" method="post">
Read more

keyboard - C++ GetAsyncKeyState alternative -

i using windows.h library's getasynckeystate function define key pushed on keyboard . here program returns int value of pushed key example. #include <iostream> #include <windows.h> using namespace std; int main (){ char i; for(i=8;i<190;i++){ if(getasynckeystate(i)== -32767){ cout<<int (i)<<endl; } } return 0; } but trying make opengl simple game , function appeared slow . there function not need cycle 180 times , if statement . thanks you're trying make opengl game, you're going use glfw. if that's case can away using glfwgetkey() such: if (glfwgetkey(glfw_key_up) == glfw_press) {...} if (glfwgetkey(glfw_key_down) == glfw_press) {...} that method nicely explained in tutorial 6 opengl-tutorial.org . should start first tutorial of beginners tutorials , later intermediate tutorials . if you're going make win32 window can listen wm_keydown or wm_keyup messages , virtua
Read more

android - java.net.UnknownHostException(Unable to resolve host “URL”: No address associated with hostname) -

i developing app testing asp.net webservice in android.for simple webservice adding 2 numbers used.where numbers passed parameters.the result in dialogue.the webserver works in local. when application runs following result exception.i provided internet permission in manifest. java.net.unknownhostexception(unable resolve host “ http://url.com/ ”: no address associated hostname) my code given below main activity public static string rslt=""; /** called when activity first created. */ @override public void oncreate(bundle savedinstancestate) { super.oncreate(savedinstancestate); setcontentview(r.layout.activity_main); button b1=(button)findviewbyid(r.id.button1); final alertdialog ad=new alertdialog.builder(this).create(); b1.setonclicklistener(new onclicklistener() { @override public void onclick(view arg0) { // todo auto-generated method stub try {
Read more