ruby on rails 3.2 - How to write a function for the day AFTER Thanksgiving? Holiday gem, YAML files -


i'm writing app tracks time-off via date ranges, , part of calculations make sure exclude weekends , holidays. in order keep track of holidays i'm using forked version of holidays gem(https://github.com/alexdunae/holidays), editing recognize holidays company recognizes. fork: (https://github.com/rclark4/holidays).

so far has worked fine me, i've run problem day after thanksgiving, addition original gem. excerpt of yaml file looks like:

  11:    - name: thanksgiving     week: 4     regions: [us]     wday: 4   - name: day after thanksgiving     week: 4     regions: [us]     wday: 5

while works 2008-2012, doesn't work in 2013 (and won't every 6-7 years), because november starts on friday, right it's saying day after thanksgiving week before is. i've tried @ syntax of other holidays see if there precedent holidays happened day after floating holiday, couldn't find 1 (the closest thing found friday easter, easter has it's own separate method altogether). ideas on how write function this?

let me know if need more information!

shawn's answer correct supposed put region specific methods in original file. idea is, shouldn't need touch .rb files make new definition, .yaml files. lib/holidays.rb general code rules (like to_weekday_if_weekend, etc.), not rules specific region. know it's kind of confusing works if don't follow rules exactly, upcoming release (hopefully) summer change soon.

so in us.yaml november should be:

11:  - name: thanksgiving   week: 4   regions: [us]   wday: 4 - name: day after thanksgiving   function: day_after_thanksgiving(year)   regions: [us]

and under methods in same file (where us_inauguration_day defined, @ least in master version) should be:

methods: us_inauguration_day: | # january 20, every fourth year, following presidential election    def self.us_inauguration_day(year)      year % 4 == 1 ? 20 : nil    end day_after_thanksgiving: |   def self.day_after_thanksgiving(year)     date.civil(year,11,date.calculate_mday(year,11,:fourth,:thursday)+1)   end

then run rake defs:build_all (run rake defs:manifest when add new region file) , pulled copy match against test, reference:

tests: |   {  date.civil(2008,11,27) => 'thanksgiving',      date.civil(2008,11,28) => 'day after thanksgiving'}.each |date, name|        assert_equal name, (holidays.on(date, :us)[0] || {})[:name]      end

Comments

Post a Comment

Popular posts from this blog

jquery - How can I dynamically add a browser tab? -

since using iframes house external pages are, accounts "not preferred method" , disallowed sites (flickr, one), want dynamically generate browser tabs. e.g., when user submits form, want dynamically generate tab on browser in response submitted. e.g., might want add new tab url like: http://www.bigsurgarrapata.com/contact how in jquery? you want form target attribute action attribute. http://www.w3schools.com/tags/att_form_target.asp browsers have ultimate control on result of target attribute open new tab value of _blank. <form action="contact_submit.php" target="_blank" method="post">
Read more

node.js - Getting the socket id,user id pair of a logged in user(s) -

i have web application done using node js , in it,i have authentication system requires users log in before can access pages. have 2 pages,the homepage , updates page. from read docs,a new socket id issued when user opens tab in browser. me being admin,i know socket id of logged in user , more so,the socket id,logged in user id pair logged in users. what method can use socket id,logged in user id pair make sure broadcast realtime info users online?.
Read more

keyboard - C++ GetAsyncKeyState alternative -

i using windows.h library's getasynckeystate function define key pushed on keyboard . here program returns int value of pushed key example. #include <iostream> #include <windows.h> using namespace std; int main (){ char i; for(i=8;i<190;i++){ if(getasynckeystate(i)== -32767){ cout<<int (i)<<endl; } } return 0; } but trying make opengl simple game , function appeared slow . there function not need cycle 180 times , if statement . thanks you're trying make opengl game, you're going use glfw. if that's case can away using glfwgetkey() such: if (glfwgetkey(glfw_key_up) == glfw_press) {...} if (glfwgetkey(glfw_key_down) == glfw_press) {...} that method nicely explained in tutorial 6 opengl-tutorial.org . should start first tutorial of beginners tutorials , later intermediate tutorials . if you're going make win32 window can listen wm_keydown or wm_keyup messages , virtua
Read more